Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pre-commit.ci] pre-commit autoupdate#12741

Merged
Pierre-Sassoulas merged 2 commits into
mainfrom
pre-commit-ci-update-config
Aug 27, 2024
Merged

[pre-commit.ci] pre-commit autoupdate#12741
Pierre-Sassoulas merged 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

pre-commit-ci Bot and others added 2 commits August 26, 2024 22:47
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2)
- [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2)
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from 8e2f001 to 8e86ac5 Compare August 27, 2024 21:04
@Pierre-Sassoulas

Copy link
Copy Markdown
Member

@nicoddemus I fixed readthedoc by changing your temporary fix to something that is going to work if new versions of towncrier are released without sphinx-contrib/sphinxcontrib-towncrier#92 being resolved (8e86ac5), I'll let you review this part.

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks @Pierre-Sassoulas

@Pierre-Sassoulas Pierre-Sassoulas merged commit 05c43af into main Aug 27, 2024
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch August 27, 2024 21:32
nicoddemus pushed a commit that referenced this pull request Aug 29, 2024
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2)
- [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2)

* Fix sphinx with a more robust fix

Until sphinx-contrib/sphinxcontrib-towncrier#92 is resolved.

Co-authored-by: Pierre Sassoulas <[email protected]>
# Pin towncrier temporarily due to incompatibility with sphinxcontrib-towncrier:
# https://github.com/sphinx-contrib/sphinxcontrib-towncrier/issues/92
towncrier!=24.7.0,!=24.7.1
towncrier<24.7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Sassoulas I wanted to revert the PR, but it contains more things than this line… FYI, the extension is now compatible with new Towncrier.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be only 2 conflicts during the revert and we can keep the line with the higher value each time.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's probably better to start from scratch.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was just being lazy in the middle of the night :) So I figured I'd at least leave a notification in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants