preserve source positions for assertion rewriting#12815
Merged
Conversation
f9cce85 to
2e8d192
Compare
2e8d192 to
e371879
Compare
d7aa2d0 to
5412956
Compare
5412956 to
0e75861
Compare
nicoddemus
requested changes
Oct 4, 2024
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks a lot @15r10nk for the PR, we really appreciate it!
Everything looks reasonable to me, appreciate the extensive tests.
Left a few minor suggestions, otherwise LGTM!
Contributor
Author
|
thank you @nicoddemus for the review. I applied your requested changes. |
a8cea83 to
5c25c59
Compare
Contributor
Author
|
I commented it, squashed it and rebased it. |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12867 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12818