Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

eqvinox
Copy link

@eqvinox eqvinox commented May 7, 2021

(Our testcases produce wireshark pcap files...)

@BeyondEvil
Copy link
Contributor

Does it really makes sense to add this in a self-contained report?

@eqvinox
Copy link
Author

eqvinox commented Jan 26, 2022

Does it really makes sense to add this in a self-contained report?

For any network-heavy software being tested, pcap files are equivalent (if not above) in importance to logfiles, so I don't really have any doubt in a "yes" to that. Especially since that's just one (pretty wide) use case, there's probably a bunch of others. Trying to think of some others, testing (de-)serialization feels like something where attaching random binaries would be pretty useful too.

@BeyondEvil
Copy link
Contributor

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.

But maybe I'm misunderstanding something here? @eqvinox

@eqvinox
Copy link
Author

eqvinox commented Jan 26, 2022

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.

But maybe I'm misunderstanding something here? @eqvinox

@BeyondEvil when you click the link for the file, the browser will open a file download dialog and save it decoded. (The download dialog would probably list wireshark too, as an application to directly open the file with. The file is first saved to /tmp for that, same way all "open with" downloads work.)

@BeyondEvil BeyondEvil added the next-gen Candidate for the next-gen project label Jan 26, 2022
@BeyondEvil
Copy link
Contributor

Ah, got it. Ok, I'll add this to next-gen. Thanks!

@BeyondEvil
Copy link
Contributor

Missed this is during initial work of v4. Will try to get to it now.

@BeyondEvil
Copy link
Contributor

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.
But maybe I'm misunderstanding something here? @eqvinox

@BeyondEvil when you click the link for the file, the browser will open a file download dialog and save it decoded. (The download dialog would probably list wireshark too, as an application to directly open the file with. The file is first saved to /tmp for that, same way all "open with" downloads work.)

I'm not seeing the behavior described here.

When I click the link, it just opens a new tab displaying the path to the binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-gen Candidate for the next-gen project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants