Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore: Fix npm building #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Chore: Fix npm building #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ jobs:
with:
node-version: '16.x'

- name: Install dependencies
run: npm ci

- name: Build app.js
run: npm run build:ci

- name: Build and Check Package
uses: hynek/build-and-inspect-python-package@v1

Expand Down
20 changes: 1 addition & 19 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- master

schedule:
- cron: '1 0 * * *' # Run daily at 0:01 UTC
- cron: '0 14 * * *' # Run daily at 14:00 UTC

pull_request:

Expand Down Expand Up @@ -46,12 +46,6 @@ jobs:
with:
node-version: '16.x'

- name: Install dependencies
run: npm ci

- name: Build app.js
run: npm run build:ci

- name: Build and Check Package
uses: hynek/build-and-inspect-python-package@v1

Expand Down Expand Up @@ -129,12 +123,6 @@ jobs:
with:
node-version: '16.x'

- name: Install dependencies
run: npm ci

- name: Build app
run: npm run build:ci

- name: Set up python
uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -203,12 +191,6 @@ jobs:
with:
node-version: '16.x'

- name: Install dependencies
run: npm ci

- name: Build app
run: npm run build:ci

- name: Set up python
uses: actions/setup-python@v4
with:
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"scripts": {
"unit": "nyc mocha testing/**/unittest.js",
"build:ci": "npm run build:css && npm run build:jsapp",
"build": "npm run build:css && npm run build:jsapp",
"build:css": "sass --no-source-map --no-error-css src/layout/css/style.scss src/pytest_html/resources/style.css",
"build:jsapp": "browserify ./src/pytest_html/scripts/index.js > ./src/pytest_html/resources/app.js",
"build": "npm run unit && npm run build:css && npm run build:jsapp",
"lint": "eslint src/pytest_html/scripts/ testing/"
"lint": "eslint src/pytest_html/scripts/ testing/",
"unit": "nyc mocha testing/**/unittest.js",
"all": "npm run lint && npm run unit && npm run build:css && npm run build:jsapp"
},
"devDependencies": {
"browserify": "^17.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

class NpmBuildHook(BuildHookInterface):
def initialize(self, version, build_data):
subprocess.check_output("npm install", shell=True)
subprocess.check_output("npm ci", shell=True)
subprocess.check_output("npm run build", shell=True)