feat(dev-hub) Pyth Pro pages Part-1 #3191
Merged
+1,453
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
cprussin
approved these changes
Nov 12, 2025
alexcambose
reviewed
Nov 13, 2025
| { id: "description", name: "Description" }, | ||
| { id: "name", name: "Name" }, | ||
| { id: "symbol", name: "Symbol" }, | ||
| { id: "pyth_lazer_id", name: "Pyth Pro ID", isRowHeader: true }, |
Contributor
There was a problem hiding this comment.
nit maybe ux wise if this is going to be sorted by it should be the first column in the table?
Member
Author
There was a problem hiding this comment.
I thought about it before. Since the pyth_pro_id starts from 1 and sequentially incremented, it can confused with the index. Sicne folks try to read the symbol and description and then refer to the pro_id, it would be better we keep it on the right side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?