Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable Codecov comments #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 13, 2022

Override the global yml in https://app.codecov.io/account/gh/python/yaml:

comment: false
coverage:
  status:
    changes: false
    patch: false
    project: false

Docs: https://docs.codecov.com/docs/codecov-yaml

@Mariatta
Copy link
Member

Should the filename be codecov.yml without the . in front?

@hugovk
Copy link
Member Author

hugovk commented Apr 13, 2022

It can be with or without:

Can I name the file .codecov.yml?

Yes. However, the file must still be located in the repository root, dev/, or .github/ directories

https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml

I find it a bit neater to hide these config files with dots, but can change if you like, and/or move to .github.


Checking an earlier commit in the new "web experience", it has a link to "view yml" with it shows this with comment: false:

image

https://app.codecov.io/gh/python/bedevere/commit/4c10bf25a59089a90e3df64f2b37ab41262d12c5

Checking this PR's commit, it now says comment: true:

https://app.codecov.io/gh/python/bedevere/commit/742296fa9dd4c2e4443c931266637fad67a5dbae

codecov:
  require_ci_to_pass: true
comment: true
coverage:
  precision: 2
  range:
  - 70.0
  - 100.0
  round: down
  status:
    changes: false
    default_rules:
      flag_coverage_not_uploaded_behavior: include
    patch: false
    project: false
github_checks:
  annotations: true

@Mariatta
Copy link
Member

Ok sounds good, lets try to merge and see if it fixes things.

@Mariatta Mariatta merged commit ffa5eef into python:master Apr 13, 2022
@hugovk hugovk deleted the codecov-comment-true branch April 13, 2022 17:24
@thomasrockhu-codecov
Copy link

thomasrockhu-codecov commented Apr 18, 2022

Tom from Codecov here. Just saw this PR and wanted to offer my help in case you ran into any issues.

Looking at the global yaml, I'd recommend changing to

comment: false
coverage:
  status:
    changes: false
    patch:
      default:
        informational: true
    project:
      default:
        informational: true

to get non-blocking status checks on PRs

@ezio-melotti
Copy link
Member

Hi @thomasrockhu-codecov, thanks for the suggestion!
@hugovk, can you look into this and possibly open a new issue/PR so that it doesn't get forgotten?

@hugovk
Copy link
Member Author

hugovk commented Apr 25, 2022

@ezio-melotti Done! #441

@thomasrockhu-codecov Thanks, let's try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants