Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Group dependabot updates #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 1, 2024

Open one grouped PR per month instead of many, to help deal with notification fatigue.

Compare first two repos with the last:

image

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (536a5f2) to head (08e2cc2).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #632   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2148      2148           
  Branches       245       245           
=========================================
  Hits          2148      2148           
Flag Coverage Δ
Python_3.10.13 100.00% <ø> (ø)
Python_3.11.8 100.00% <ø> (ø)
Python_3.12.2 100.00% <ø> (ø)
Python_3.8.18 100.00% <ø> (ø)
Python_3.9.18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank god

@hugovk hugovk merged commit f47538c into python:main Mar 1, 2024
@hugovk hugovk deleted the grouped-dependencies branch March 1, 2024 21:12
@ezio-melotti
Copy link
Member

ezio-melotti commented Mar 1, 2024

FWIW I don't mind dealing with them separately, which I find generally easier than a single PR with multiple updates. I'm also auto assigned to them and I generally review and merge them all within a day (as you can see from Hugo's screenshot). I understand that this still creates a number of notifications for other people, but they can generally ignore them and/or mark them as "done", especially if I already reviewed and merged them.

Unfortunately @dependabot will always submit monthly updates on the first day of the month, and that results in a large number of notification on the first of each month. For weekly updates it's possible to set the day of the week -- if it was possible to set the day for monthly releases too we might have been able to stagger the PR from different repos on different days.

I'm also ok with being auto-assigned on more repositories, since once I read the updates notes for one dependency, it's generally safe (and easy) to merge all corresponding PRs across all repos I manage.

@hugovk
Copy link
Member Author

hugovk commented Mar 1, 2024

In just the last day, I've received 21 Dependabot notifications from 7 repos (across 4 organisations).

Also in one day, from Renovate (similar to Dependabot) I've received 17 notifications from 8 repos (across 5 orgs).

(btw Renovate allows selecting day-of-week staggering monthly updates. We've set Pillow repos to trigger on different days, and avoid tying up the CI on potential release days.)

Luckily today was the first day of the month and not the first of the quarter, or I would have had a raft of pre-commit updates too.

Instead of 38 notifications, if we can have these closer to 15, it would be much better. Each of these notifications pushes others further down the list. Even if it's easy to dismiss, they all add to "notification/alert fatigue" that can contribute to burnout. (I've seen some projects turn off Dependabot because of the perceived noise, but I'm not suggesting that.)

Having separate PRs uses up more CI time: often when merging one, the next in the list is rebased, meaning you need to wait another couple of minutes. Repeat x 5. Having so many PRs in the tracker can also make it harder to search for things later.

We have a bit of a special case about Codecov (let's talk about how to handle that another time), but usually it doesn't really matter if they're one-by-one or all-at-once. Sometimes they need to be done together (the recent actions/upload-artifact and download-artifact updates).

See also python/python-docs-theme#170 (comment).

@hugovk
Copy link
Member Author

hugovk commented Mar 1, 2024

PS Between starting writing and posting that, an extra 5 Dependabot notifications have come in from 2 more repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants