Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not send "buildbot went away" emails to the buildbot-status maling list #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pablogsal opened this issue Jan 25, 2020 · 5 comments · Fixed by #592
Closed

Do not send "buildbot went away" emails to the buildbot-status maling list #162

pablogsal opened this issue Jan 25, 2020 · 5 comments · Fixed by #592

Comments

@pablogsal
Copy link
Member

@ned-deily requested that the "buildbot went away" emails are not sent to the buildbot-status mailing list. Any objections?

CC: @vstinner @zware
@vstinner
Copy link
Member

I don't see the point of these emails. Please stop to send them :-)

@zware
Copy link
Member

zware commented Jan 27, 2020

They're supposed to only be sent when a worker suddenly disappears, not every time the master is restarted (and restarts have become rather more frequent of late :)). I've pinged buildbot/buildbot#4234 about it, but if there's no change then we might as well disable them to the list:

buildmaster-config/master/custom/workers.py

Line 31 in f4ae6ba

map(str, filter(None, (settings.get("status_email", None), owner_email)))

Removing settings.get("status_email", None) here would do it.

@StanFromIreland
Copy link
Contributor

There has been no change on the buildbot side for 5 years now.

@StanFromIreland
Copy link
Contributor

Zachary's suggested patch seems to me as the way to go, as things are really going anyway on the buildbot site. I am happy to open the pr.

@pablogsal
Copy link
Member Author

Let's do it

@StanFromIreland StanFromIreland mentioned this issue May 3, 2025
Merged
@zware zware closed this as completed in #592 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop sending of "buildbot went away" emails StanFromIreland/buildmaster-config
4 participants
@vstinner @zware @pablogsal @StanFromIreland