-
-
Notifications
You must be signed in to change notification settings - Fork 60
Consider using a prefix in the title of backport PRs #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think appropriate labels would be better, otherwise we have to remember what the format is while a label is just right there and labels are more searchable. Since we have "backport to 3.6" we could add "cherry-pick for 3.6" for PRs which are an actual backport. Does that sound reasonable? |
"cherry-pick for 3.6" sounds good to me. I don't know how can I create email filters for labels though :) |
Ah, that's why you want the prefix in the title. 😉 I've gone ahead and added the appropriate labels so we can give them a try and see how it works out. |
Can we have |
Nvm just read your email to python-dev. So |
🤔 I realize that @berkerpeksag still wants to be able to filter out the backport emails. |
The way I read "backport to 3.6" is this needs to be backported to 3.6, not that it's a backport for 3.6. So if we do decide to drop the labels and go with title prefixes I would argue for |
All of your suggestions look good to me, @brettcannon. The reason I prefer title prefixes is that it's easy to notice backport PRs without using GitHub UI. See the attached screenshot. Both of them backport PRs (for 3.5 and 3.6 branches) with almost same title so it's a little bit hard to notice the difference :) |
Then try both labels and prefix for a month and see which one ends up being useful. And to unify with the labels let's go with |
Actually could GH-24 take care of this by including the labels in the title automatically? |
I might be wrong, but GH-24 is about sending an email to python-checkins when a PR ws merged. |
And so you want an email at creation instead? |
Another nice thing about issue title notations, is that then a bot can automatically add the label :) The two prefixes I've seen so far are:
Both of those seem really wordy to me, and I think a simple [X.Y] should suffice |
This is already recommended in this section of the devguide :) |
Since we are now documenting this as a thing to do, I'm closing this (I don't think we can drop the label due to the fact that search for |
As my understanding, |
Correct. I use it in only PR titles, but other projects use it in commit messages too. See Django for example. |
Can we use a prefix like
[backport to X.Y]
or[3.6]
for backport PRs? For example:This way we can easily see which PRs are backports on GitHub and we can also set appropriate email filters.
The text was updated successfully, but these errors were encountered: