-
-
Notifications
You must be signed in to change notification settings - Fork 60
Cherry-picker: Remove BACKPORT_COMPLETE. UNSET state after finished. #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checking it now. |
@Mariatta I expected that state would be reset if everything is completed successfully. How about calling |
Any non-allowed states are supposed idicate that something went wrong. |
Ok I've removed BACKPORT_COMPLETE. unset will be called instead, and using the UNSET state. |
uugh don't know what's the deal with travis π Tests-passing-locally-for-meβ’οΈ |
Oh, that's weird... Did you run all tests locally or just related? |
Hmm I ran everything |
I checked this branch locally as well and it passes. |
@Mariatta just to be on the safe side, could you please clear the cache in Travis CI? It's here https://travis-ci.org/python/core-workflow/caches |
I've cleared cache and restart the build, still no luck π€ Anyone else can try this locally? |
πππ€ @Mariatta, I've formatted these files using
|
@Mariatta I know what the problem is! π So |
Solutions:
- &install-and-test-cherry-picker
...
git:
depth: 200
... |
πππ€ @Mariatta, I've formatted these files using
|
cherry_picker/cherry_picker/test.py
Outdated
], | ||
) | ||
@mock.patch("os.path.exists") | ||
@mock.patch("cherry_picker.cherry_picker.validate_sha") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests aren't testing validate_sha itself, but the other functionalities. I think it is ok to be mocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that mocking validate_sha
is wrong. This way you'll just completely disable testing of the specific code path. It doesn't cure the root of the issue but only symptoms. Along with that, it makes the project vulnerable to regressions.
hm, but changing it to recent sha also only delays the problem, same issue will happen again in the future. |
πππ€ @Mariatta, I've formatted these files using
|
@Mariatta I think you should just make git clone deeper. Or if you're worried about the delay, it's possible to disable |
πππ€ @Mariatta, I've formatted these files using
|
Thanks, I've disabled git depth in travis CI and reverted the mocks. |
@Mariatta great! P.S. One small feedback about |
Thanks! |
No description provided.