Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Loosen README check for CPython forks #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Loosen README check for CPython forks #473

merged 3 commits into from
Mar 5, 2023

Conversation

arhadthedev
Copy link
Member

This PR supersedes gh-291. A quote from #291 (comment) for context:

If we wanted to accommodate CPython forks, we should not 'bless' Tauthon only. /Py/./ would potentially also accommodate things like 'Brython'. But it is not clear to me that we want to do this, as it would subvert part of the apparent purpose of the function that uses the RE.

@terryjreedy I believe that This is Python version 2.7 as modified and augmented by the xxx fork thereof wording is long and clumsy, and so perceived as This is Python something something... Looks like a wrong repo.

@terryjreedy
Copy link
Member

The most important part of my previous comment, four years ago, that review was needed from Larry Hastings (or someone who understood the current code) ,was ignored. Until it is determined whether any change to the re is acceptable, it is useless to discuss the exact change. This PR seems premature. I think I should have suggested a core-workflow issue.

@arhadthedev
Copy link
Member Author

arhadthedev commented Jul 24, 2022

According to dates in author:larryhastings search query for commits and for issues, he fortunately seems to be relatively active, just dedicated exclusively to other projects.

@arhadthedev
Copy link
Member Author

@larryhastings Would you mind to review and possibly merge this PR or gh-291 alternative please? Both are one-liners.

@arhadthedev
Copy link
Member Author

@larryhastings ping?

@CAM-Gerlach CAM-Gerlach requested a review from gpshead January 15, 2023 18:15
@CAM-Gerlach
Copy link
Member

FWIW, the tauthon repo hasn't seen any PR or commit activity in nearly 6 months, and only a handful of commits all by a single person in the past year+ since the final release of CPython 2.7, so it's unclear how useful this will be to them at this point. However, it could be useful for other forks that have names ending in thon (though many don't, e.g. Pyston, no-gil, etc.)

I've pinged @larryhastings through other channels, but I also want to mention @gpshead who previously reviewed and approved a previous fairly small PR similar to this one, given this is seemingly just a trivial regex.

Co-authored-by: Ezio Melotti <[email protected]>
@arhadthedev
Copy link
Member Author

@larryhastings ping?

Co-authored-by: C.A.M. Gerlach <[email protected]>
@arhadthedev
Copy link
Member Author

ping

@ezio-melotti ezio-melotti merged commit a3d461f into python:master Mar 5, 2023
@arhadthedev arhadthedev deleted the nix-like-name branch March 7, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants