-
-
Notifications
You must be signed in to change notification settings - Fork 60
Loosen README check for CPython forks #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The most important part of my previous comment, four years ago, that review was needed from Larry Hastings (or someone who understood the current code) ,was ignored. Until it is determined whether any change to the re is acceptable, it is useless to discuss the exact change. This PR seems premature. I think I should have suggested a core-workflow issue. |
According to dates in |
@larryhastings Would you mind to review and possibly merge this PR or gh-291 alternative please? Both are one-liners. |
@larryhastings ping? |
FWIW, the tauthon repo hasn't seen any PR or commit activity in nearly 6 months, and only a handful of commits all by a single person in the past year+ since the final release of CPython 2.7, so it's unclear how useful this will be to them at this point. However, it could be useful for other forks that have names ending in I've pinged @larryhastings through other channels, but I also want to mention @gpshead who previously reviewed and approved a previous fairly small PR similar to this one, given this is seemingly just a trivial regex. |
Co-authored-by: Ezio Melotti <[email protected]>
@larryhastings ping? |
Co-authored-by: C.A.M. Gerlach <[email protected]>
ping |
This PR supersedes gh-291. A quote from #291 (comment) for context:
@terryjreedy I believe that
This is Python version 2.7 as modified and augmented by the xxx fork thereof
wording is long and clumsy, and so perceived as This is Python something something... Looks like a wrong repo.