bpo-32467: Let collections.abc.ValuesView inherit from Collection (#5152)

rhettinger · web-flow · commit 02556fbade5e · 2018-01-11T21:53:49.000-08:00
diff --git a/Doc/library/collections.abc.rst b/Doc/library/collections.abc.rst
@@ -87,7 +87,8 @@ ABC                        Inherits from          Abstract Methods        Mixin
                            :class:`Set`                                   ``__iter__``
 :class:`KeysView`          :class:`MappingView`,                          ``__contains__``,
                            :class:`Set`                                   ``__iter__``
-:class:`ValuesView`        :class:`MappingView`                           ``__contains__``, ``__iter__``
+:class:`ValuesView`        :class:`MappingView`,                          ``__contains__``, ``__iter__``
+                           :class:`Collection`
 :class:`Awaitable`                                ``__await__``
 :class:`Coroutine`         :class:`Awaitable`     ``send``, ``throw``     ``close``
 :class:`AsyncIterable`                            ``__aiter__``
diff --git a/Lib/_collections_abc.py b/Lib/_collections_abc.py
@@ -746,7 +746,7 @@ def __iter__(self):
 ItemsView.register(dict_items)
 
 
-class ValuesView(MappingView):
+class ValuesView(MappingView, Collection):
 
     __slots__ = ()
 
diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py
@@ -843,13 +843,13 @@ def test_Collection(self):
             self.assertFalse(issubclass(type(x), Collection), repr(type(x)))
         # Check some non-collection iterables
         non_col_iterables = [_test_gen(), iter(b''), iter(bytearray()),
-                             (x for x in []), dict().values()]
+                             (x for x in [])]
         for x in non_col_iterables:
             self.assertNotIsInstance(x, Collection)
             self.assertFalse(issubclass(type(x), Collection), repr(type(x)))
         # Check some collections
         samples = [set(), frozenset(), dict(), bytes(), str(), tuple(),
-                   list(), dict().keys(), dict().items()]
+                   list(), dict().keys(), dict().items(), dict().values()]
         for x in samples:
             self.assertIsInstance(x, Collection)
             self.assertTrue(issubclass(type(x), Collection), repr(type(x)))
diff --git a/Misc/NEWS.d/next/Library/2018-01-11-00-33-42.bpo-32467.YVEOv6.rst b/Misc/NEWS.d/next/Library/2018-01-11-00-33-42.bpo-32467.YVEOv6.rst
@@ -0,0 +1 @@
+collections.abc.ValuesView now inherits from collections.abc.Collection.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+collections.abc.ValuesView now inherits from collections.abc.Collection.`