Issue #27007: The fromhex() class methods of bytes and bytearray subclasses

serhiy-storchaka · serhiy-storchaka · commit 0855e706aa7f · 2016-07-01T17:22:31.000+03:00
now return an instance of corresponding subclass.
diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
@@ -1589,7 +1589,32 @@ def test_copy(self):
             self.assertEqual(type(a), type(b))
             self.assertEqual(type(a.y), type(b.y))
 
-    test_fromhex = BaseBytesTest.test_fromhex
+    def test_fromhex(self):
+        b = self.type2test.fromhex('1a2B30')
+        self.assertEqual(b, b'\x1a\x2b\x30')
+        self.assertIs(type(b), self.type2test)
+
+        class B1(self.basetype):
+            def __new__(cls, value):
+                me = self.basetype.__new__(cls, value)
+                me.foo = 'bar'
+                return me
+
+        b = B1.fromhex('1a2B30')
+        self.assertEqual(b, b'\x1a\x2b\x30')
+        self.assertIs(type(b), B1)
+        self.assertEqual(b.foo, 'bar')
+
+        class B2(self.basetype):
+            def __init__(me, *args, **kwargs):
+                if self.basetype is not bytes:
+                    self.basetype.__init__(me, *args, **kwargs)
+                me.foo = 'bar'
+
+        b = B2.fromhex('1a2B30')
+        self.assertEqual(b, b'\x1a\x2b\x30')
+        self.assertIs(type(b), B2)
+        self.assertEqual(b.foo, 'bar')
 
 
 class ByteArraySubclass(bytearray):
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -7,6 +7,12 @@ What's New in Python 3.6.0 alpha 3
 
 *Release date: XXXX-XX-XX*
 
+Core and Builtins
+-----------------
+
+- Issue #27007: The fromhex() class methods of bytes and bytearray subclasses
+  now return an instance of corresponding subclass.
+
 Library
 -------
 
diff --git a/Objects/bytearrayobject.c b/Objects/bytearrayobject.c
@@ -1968,7 +1968,6 @@ bytearray_splitlines_impl(PyByteArrayObject *self, int keepends)
 @classmethod
 bytearray.fromhex
 
-    cls: self(type="PyObject*")
     string: unicode
     /
 
@@ -1979,10 +1978,15 @@ Example: bytearray.fromhex('B9 01EF') -> bytearray(b'\\xb9\\x01\\xef')
 [clinic start generated code]*/
 
 static PyObject *
-bytearray_fromhex_impl(PyObject*cls, PyObject *string)
-/*[clinic end generated code: output=df3da60129b3700c input=907bbd2d34d9367a]*/
+bytearray_fromhex_impl(PyTypeObject *type, PyObject *string)
+/*[clinic end generated code: output=8f0f0b6d30fb3ba0 input=f033a16d1fb21f48]*/
 {
-    return _PyBytes_FromHex(string, 1);
+    PyObject *result = _PyBytes_FromHex(string, type == &PyByteArray_Type);
+    if (type != &PyByteArray_Type && result != NULL) {
+        Py_SETREF(result, PyObject_CallFunctionObjArgs((PyObject *)type,
+                                                       result, NULL));
+    }
+    return result;
 }
 
 PyDoc_STRVAR(hex__doc__,
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -2303,7 +2303,12 @@ static PyObject *
 bytes_fromhex_impl(PyTypeObject *type, PyObject *string)
 /*[clinic end generated code: output=0973acc63661bb2e input=bf4d1c361670acd3]*/
 {
-    return _PyBytes_FromHex(string, 0);
+    PyObject *result = _PyBytes_FromHex(string, 0);
+    if (type != &PyBytes_Type && result != NULL) {
+        Py_SETREF(result, PyObject_CallFunctionObjArgs((PyObject *)type,
+                                                       result, NULL));
+    }
+    return result;
 }
 
 PyObject*
diff --git a/Objects/clinic/bytearrayobject.c.h b/Objects/clinic/bytearrayobject.c.h
@@ -636,18 +636,18 @@ PyDoc_STRVAR(bytearray_fromhex__doc__,
     {"fromhex", (PyCFunction)bytearray_fromhex, METH_O|METH_CLASS, bytearray_fromhex__doc__},
 
 static PyObject *
-bytearray_fromhex_impl(PyObject*cls, PyObject *string);
+bytearray_fromhex_impl(PyTypeObject *type, PyObject *string);
 
 static PyObject *
-bytearray_fromhex(PyTypeObject *cls, PyObject *arg)
+bytearray_fromhex(PyTypeObject *type, PyObject *arg)
 {
     PyObject *return_value = NULL;
     PyObject *string;
 
     if (!PyArg_Parse(arg, "U:fromhex", &string)) {
         goto exit;
     }
-    return_value = bytearray_fromhex_impl((PyObject*)cls, string);
+    return_value = bytearray_fromhex_impl(type, string);
 
 exit:
     return return_value;
@@ -716,4 +716,4 @@ bytearray_sizeof(PyByteArrayObject *self, PyObject *Py_UNUSED(ignored))
 {
     return bytearray_sizeof_impl(self);
 }
-/*[clinic end generated code: output=044a6c26a836bcfe input=a9049054013a1b77]*/
+/*[clinic end generated code: output=a32f183ebef159cc input=a9049054013a1b77]*/

Original file line number	Diff line number	Diff line change
`@@ -2303,7 +2303,12 @@ static PyObject *`
`2303`	`2303`	`bytes_fromhex_impl(PyTypeObject type, PyObject string)`
`2304`	`2304`	`/[clinic end generated code: output=0973acc63661bb2e input=bf4d1c361670acd3]/`
`2305`	`2305`	`{`
`2306`		`- return _PyBytes_FromHex(string, 0);`
	`2306`	`+ PyObject *result = _PyBytes_FromHex(string, 0);`
	`2307`	`+ if (type != &PyBytes_Type && result != NULL) {`
	`2308`	`+ Py_SETREF(result, PyObject_CallFunctionObjArgs((PyObject *)type,`
	`2309`	`+ result, NULL));`
	`2310`	`+ }`
	`2311`	`+ return result;`
`2307`	`2312`	`}`
`2308`	`2313`
`2309`	`2314`	`PyObject*`
Original file line number	Diff line number	Diff line change
`@@ -636,18 +636,18 @@ PyDoc_STRVAR(bytearray_fromhex__doc__,`
`636`	`636`	`{"fromhex", (PyCFunction)bytearray_fromhex, METH_O\|METH_CLASS, bytearray_fromhex__doc__},`
`637`	`637`
`638`	`638`	`static PyObject *`
`639`		`-bytearray_fromhex_impl(PyObjectcls, PyObject string);`
	`639`	`+bytearray_fromhex_impl(PyTypeObject type, PyObject string);`
`640`	`640`
`641`	`641`	`static PyObject *`
`642`		`-bytearray_fromhex(PyTypeObject cls, PyObject arg)`
	`642`	`+bytearray_fromhex(PyTypeObject type, PyObject arg)`
`643`	`643`	`{`
`644`	`644`	`PyObject *return_value = NULL;`
`645`	`645`	`PyObject *string;`
`646`	`646`
`647`	`647`	`if (!PyArg_Parse(arg, "U:fromhex", &string)) {`
`648`	`648`	`goto exit;`
`649`	`649`	`}`
`650`		`- return_value = bytearray_fromhex_impl((PyObject*)cls, string);`
	`650`	`+ return_value = bytearray_fromhex_impl(type, string);`
`651`	`651`
`652`	`652`	`exit:`
`653`	`653`	`return return_value;`
`@@ -716,4 +716,4 @@ bytearray_sizeof(PyByteArrayObject self, PyObject Py_UNUSED(ignored))`
`716`	`716`	`{`
`717`	`717`	`return bytearray_sizeof_impl(self);`
`718`	`718`	`}`
`719`		`-/[clinic end generated code: output=044a6c26a836bcfe input=a9049054013a1b77]/`
	`719`	`+/[clinic end generated code: output=a32f183ebef159cc input=a9049054013a1b77]/`