fix refleak

benjaminp · benjaminp · commit 0a4dae5309ab · 2010-11-21T15:12:34.000Z
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -376,6 +376,7 @@ def sumTrailer(self, name, add_label=False):
         self.emit(format % error, 1, reflow=False)
         if add_label:
             self.emit("failed:", 1)
+            self.emit("Py_XDECREF(tmp);", 1)
         self.emit("return 1;", 1)
         self.emit("}", 0)
         self.emit("", 0)
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
@@ -3516,6 +3516,7 @@ obj2ast_mod(PyObject* obj, mod_ty* out, PyArena* arena)
 
         PyErr_Format(PyExc_TypeError, "expected some sort of mod, but got %R", obj);
         failed:
+        Py_XDECREF(tmp);
         return 1;
 }
 
@@ -4711,6 +4712,7 @@ obj2ast_stmt(PyObject* obj, stmt_ty* out, PyArena* arena)
 
         PyErr_Format(PyExc_TypeError, "expected some sort of stmt, but got %R", obj);
         failed:
+        Py_XDECREF(tmp);
         return 1;
 }
 
@@ -5826,6 +5828,7 @@ obj2ast_expr(PyObject* obj, expr_ty* out, PyArena* arena)
 
         PyErr_Format(PyExc_TypeError, "expected some sort of expr, but got %R", obj);
         failed:
+        Py_XDECREF(tmp);
         return 1;
 }
 
@@ -6006,6 +6009,7 @@ obj2ast_slice(PyObject* obj, slice_ty* out, PyArena* arena)
 
         PyErr_Format(PyExc_TypeError, "expected some sort of slice, but got %R", obj);
         failed:
+        Py_XDECREF(tmp);
         return 1;
 }
 
@@ -6438,6 +6442,7 @@ obj2ast_excepthandler(PyObject* obj, excepthandler_ty* out, PyArena* arena)
 
         PyErr_Format(PyExc_TypeError, "expected some sort of excepthandler, but got %R", obj);
         failed:
+        Py_XDECREF(tmp);
         return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3516,6 +3516,7 @@ obj2ast_mod(PyObject* obj, mod_ty* out, PyArena* arena)`
`3516`	`3516`
`3517`	`3517`	`PyErr_Format(PyExc_TypeError, "expected some sort of mod, but got %R", obj);`
`3518`	`3518`	`failed:`
	`3519`	`+ Py_XDECREF(tmp);`
`3519`	`3520`	`return 1;`
`3520`	`3521`	`}`
`3521`	`3522`
`@@ -4711,6 +4712,7 @@ obj2ast_stmt(PyObject* obj, stmt_ty* out, PyArena* arena)`
`4711`	`4712`
`4712`	`4713`	`PyErr_Format(PyExc_TypeError, "expected some sort of stmt, but got %R", obj);`
`4713`	`4714`	`failed:`
	`4715`	`+ Py_XDECREF(tmp);`
`4714`	`4716`	`return 1;`
`4715`	`4717`	`}`
`4716`	`4718`
`@@ -5826,6 +5828,7 @@ obj2ast_expr(PyObject* obj, expr_ty* out, PyArena* arena)`
`5826`	`5828`
`5827`	`5829`	`PyErr_Format(PyExc_TypeError, "expected some sort of expr, but got %R", obj);`
`5828`	`5830`	`failed:`
	`5831`	`+ Py_XDECREF(tmp);`
`5829`	`5832`	`return 1;`
`5830`	`5833`	`}`
`5831`	`5834`
`@@ -6006,6 +6009,7 @@ obj2ast_slice(PyObject* obj, slice_ty* out, PyArena* arena)`
`6006`	`6009`
`6007`	`6010`	`PyErr_Format(PyExc_TypeError, "expected some sort of slice, but got %R", obj);`
`6008`	`6011`	`failed:`
	`6012`	`+ Py_XDECREF(tmp);`
`6009`	`6013`	`return 1;`
`6010`	`6014`	`}`
`6011`	`6015`
`@@ -6438,6 +6442,7 @@ obj2ast_excepthandler(PyObject* obj, excepthandler_ty* out, PyArena* arena)`
`6438`	`6442`
`6439`	`6443`	`PyErr_Format(PyExc_TypeError, "expected some sort of excepthandler, but got %R", obj);`
`6440`	`6444`	`failed:`
	`6445`	`+ Py_XDECREF(tmp);`
`6441`	`6446`	`return 1;`
`6442`	`6447`	`}`
`6443`	`6448`