Fix SF #1001053, wave.open() with unicode filename fails

nnorwitz · nnorwitz · commit 0e67fd478f04 · 2004-08-01T22:48:06.000Z
Backport candidate.
diff --git a/Lib/wave.py b/Lib/wave.py
@@ -155,7 +155,7 @@ def initfp(self, file):
 
     def __init__(self, f):
         self._i_opened_the_file = None
-        if type(f) == type(''):
+        if isinstance(f, basestring):
             f = __builtin__.open(f, 'rb')
             self._i_opened_the_file = f
         # else, assume it is an open file object already
@@ -294,7 +294,7 @@ class Wave_write:
 
     def __init__(self, f):
         self._i_opened_the_file = None
-        if type(f) == type(''):
+        if isinstance(f, basestring):
             f = __builtin__.open(f, 'wb')
             self._i_opened_the_file = f
         self.initfp(f)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -46,6 +46,8 @@ Extension modules
 Library
 -------
 
+- Bug #1001053.  wave.open() now accepts unicode filenames.
+
 - gzip.GzipFile has a new fileno() method, to retrieve the handle of the
   underlying file object (provided it has a fileno() method).  This is
   needed if you want to use os.fsync() on a GzipFile.
