PySymtableEntry_New(): I'm not sure what this routine is doing, but it

tim-one · tim-one · commit 0f2d4b84a60e · 2001-12-08T23:40:38.000Z
was obviously leaking an int object when whatever the heck it's looking for
was found.  Repaired that.  This accounts for why entering function and
class definitions at an interactive prompt leaked a reference to the
integer 1 each time.
Bugfix candidate.
diff --git a/Python/symtable.c b/Python/symtable.c
@@ -15,6 +15,7 @@ PySymtableEntry_New(struct symtable *st, char *name, int type, int lineno)
 		goto fail;
 	v = PyDict_GetItem(st->st_symbols, k);
 	if (v) /* XXX could check that name, type, lineno match */ {
+		Py_DECREF(k);
 		Py_INCREF(v);
 		return v;
 	}

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ PySymtableEntry_New(struct symtable st, char name, int type, int lineno)`
`15`	`15`	`goto fail;`
`16`	`16`	`v = PyDict_GetItem(st->st_symbols, k);`
`17`	`17`	`if (v) /* XXX could check that name, type, lineno match */ {`
	`18`	`+ Py_DECREF(k);`
`18`	`19`	`Py_INCREF(v);`
`19`	`20`	`return v;`
`20`	`21`	`}`