SF bug 681122: Built-in function dir() causes refcount leak in baseclasses.

tim-one · tim-one · commit 18e7083cda52 · 2003-02-05T19:35:19.000Z
merge_class_dict():  This was missing a decref.

Bugfix candidate.
diff --git a/Objects/object.c b/Objects/object.c
@@ -1656,12 +1656,15 @@ merge_class_dict(PyObject* dict, PyObject* aclass)
 			PyErr_Clear();
 		else {
 			for (i = 0; i < n; i++) {
+				int status;
 				PyObject *base = PySequence_GetItem(bases, i);
 				if (base == NULL) {
 					Py_DECREF(bases);
 					return -1;
 				}
-				if (merge_class_dict(dict, base) < 0) {
+				status = merge_class_dict(dict, base);
+				Py_DECREF(base);
+				if (status < 0) {
 					Py_DECREF(bases);
 					return -1;
 				}
