Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 19c899c

Browse files
committed
Issue #20957: test_smtpnet now uses support.transient_internet() to call
check_ssl_verifiy(), so only test_connect_using_sslcontext_verified() is skipped if smtp.gmail.com cannot be joined, not the whole file.
1 parent 2bb8a08 commit 19c899c

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

Lib/test/test_smtpnet.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ def test_connect_starttls(self):
4242
class SmtpSSLTest(unittest.TestCase):
4343
testServer = 'smtp.gmail.com'
4444
remotePort = 465
45-
can_verify = check_ssl_verifiy(testServer, remotePort)
4645

4746
def test_connect(self):
4847
support.get_attribute(smtplib, 'SMTP_SSL')
@@ -66,8 +65,12 @@ def test_connect_using_sslcontext(self):
6665
server.ehlo()
6766
server.quit()
6867

69-
@unittest.skipUnless(can_verify, "SSL certificate can't be verified")
7068
def test_connect_using_sslcontext_verified(self):
69+
with support.transient_internet(self.testServer):
70+
can_verify = check_ssl_verifiy(self.testServer, self.remotePort)
71+
if not can_verify:
72+
self.skipTest("SSL certificate can't be verified")
73+
7174
support.get_attribute(smtplib, 'SMTP_SSL')
7275
context = ssl.create_default_context()
7376
with support.transient_internet(self.testServer):

0 commit comments

Comments
 (0)