Bug #801349: document that start/stop/step slice arguments can be None

birkenfeld · birkenfeld · commit 1dc5a84aee51 · 2006-02-19T00:12:42.000Z
diff --git a/Doc/lib/libstdtypes.tex b/Doc/lib/libstdtypes.tex
@@ -532,9 +532,10 @@ \subsection{Sequence Types ---
 \item[(4)] The slice of \var{s} from \var{i} to \var{j} is defined as
   the sequence of items with index \var{k} such that \code{\var{i} <=
   \var{k} < \var{j}}.  If \var{i} or \var{j} is greater than
-  \code{len(\var{s})}, use \code{len(\var{s})}.  If \var{i} is omitted,
-  use \code{0}.  If \var{j} is omitted, use \code{len(\var{s})}.  If
-  \var{i} is greater than or equal to \var{j}, the slice is empty.
+  \code{len(\var{s})}, use \code{len(\var{s})}.  If \var{i} is omitted
+  or \code{None}, use \code{0}.  If \var{j} is omitted or \code{None},
+  use \code{len(\var{s})}.  If \var{i} is greater than or equal to \var{j},
+  the slice is empty.
 
 \item[(5)] The slice of \var{s} from \var{i} to \var{j} with step
   \var{k} is defined as the sequence of items with index 
@@ -543,9 +544,9 @@ \subsection{Sequence Types ---
   are \code{i}, \code{i+k}, \code{i+2*k}, \code{i+3*k} and so on, stopping when
   \var{j} is reached (but never including \var{j}).  If \var{i} or \var{j}
   is greater than \code{len(\var{s})}, use \code{len(\var{s})}.  If
-  \var{i} or \var{j} are omitted then they become ``end'' values
+  \var{i} or \var{j} are omitted or \code{None}, they become ``end'' values
   (which end depends on the sign of \var{k}).  Note, \var{k} cannot
-  be zero.
+  be zero. If \var{k} is \code{None}, it is treated like \code{1}.
 
 \item[(6)] If \var{s} and \var{t} are both strings, some Python
 implementations such as CPython can usually perform an in-place optimization
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -3905,7 +3905,7 @@ _PyEval_SliceIndex(PyObject *v, Py_ssize_t *pi)
 			}
 		} else {
 			PyErr_SetString(PyExc_TypeError,
-					"slice indices must be integers");
+					"slice indices must be integers or None");
 			return 0;
 		}
 		*pi = x;

Original file line number	Diff line number	Diff line change
`@@ -3905,7 +3905,7 @@ _PyEval_SliceIndex(PyObject v, Py_ssize_t pi)`
`3905`	`3905`	`}`
`3906`	`3906`	`} else {`
`3907`	`3907`	`PyErr_SetString(PyExc_TypeError,`
`3908`		`- "slice indices must be integers");`
	`3908`	`+ "slice indices must be integers or None");`
`3909`	`3909`	`return 0;`
`3910`	`3910`	`}`
`3911`	`3911`	`*pi = x;`