fix zipimport ref leak

benjaminp · benjaminp · commit 21e7d4cd5eb5 · 2014-01-09T09:36:10.000-06:00
diff --git a/Modules/zipimport.c b/Modules/zipimport.c
@@ -958,10 +958,8 @@ safely_reopen_archive(ZipImporter *self)
             }
             Py_XDECREF(self->files);  /* free the old value. */
             self->files = files;
-        } else {
-            /* No problem, discard the new stat data. */
-            Py_DECREF(stat_now);
         }
+        Py_DECREF(stat_now);
     }  /* stat succeeded */
 
     return fp;

Original file line number	Diff line number	Diff line change
`@@ -958,10 +958,8 @@ safely_reopen_archive(ZipImporter *self)`
`958`	`958`	`}`
`959`	`959`	`Py_XDECREF(self->files); /* free the old value. */`
`960`	`960`	`self->files = files;`
`961`		`- } else {`
`962`		`- /* No problem, discard the new stat data. */`
`963`		`- Py_DECREF(stat_now);`
`964`	`961`	`}`
	`962`	`+ Py_DECREF(stat_now);`
`965`	`963`	`} /* stat succeeded */`
`966`	`964`
`967`	`965`	`return fp;`