Use 'S' format character for the optional constructor argument, so we

gvanrossum · gvanrossum · commit 2a502d8304cd · 1998-07-24T19:53:54.000Z
get a decent error message when it's not a string (instead of
confusing errors when trying to use the thing).
diff --git a/Modules/cStringIO.c b/Modules/cStringIO.c
@@ -565,7 +565,7 @@ static PyObject *
 IO_StringIO(PyObject *self, PyObject *args) {
   PyObject *s=0;
 
-  UNLESS(PyArg_ParseTuple(args, "|O", &s)) return NULL;
+  UNLESS(PyArg_ParseTuple(args, "|S", &s)) return NULL;
   if(s) return newIobject(s);
   return newOobject(128);
 }

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ static PyObject *`
`565`	`565`	`IO_StringIO(PyObject self, PyObject args) {`
`566`	`566`	`PyObject *s=0;`
`567`	`567`
`568`		`- UNLESS(PyArg_ParseTuple(args, "\|O", &s)) return NULL;`
	`568`	`+ UNLESS(PyArg_ParseTuple(args, "\|S", &s)) return NULL;`
`569`	`569`	`if(s) return newIobject(s);`
`570`	`570`	`return newOobject(128);`
`571`	`571`	`}`