Change copy.replace() to raise TypeError for unkown fields for named tuples

XuehaiPan · XuehaiPan · commit 350a3d04fa62 · 2023-10-03T01:18:32.000+08:00
diff --git a/Lib/collections/__init__.py b/Lib/collections/__init__.py
@@ -457,7 +457,7 @@ def _make(cls, iterable):
     def _replace(self, /, **kwds):
         result = self._make(_map(kwds.pop, field_names, self))
         if kwds:
-            raise ValueError(f'Got unexpected field name(s): {list(kwds)!r}')
+            raise TypeError(f'Got unexpected field name(s): {list(kwds)!r}')
         return result
 
     _replace.__doc__ = (f'Return a new {typename} object replacing specified '
diff --git a/Objects/structseq.c b/Objects/structseq.c
@@ -388,11 +388,11 @@ structseq_replace(PyStructSequence *self, PyObject *args, PyObject *kwargs)
     if (n_unnamed_fields < 0) {
         return NULL;
     }
+
     tup = _PyTuple_FromArray(self->ob_item, n_visible_fields);
     if (!tup) {
         goto error;
     }
-
     dict = PyDict_New();
     if (!dict) {
         goto error;
@@ -428,7 +428,7 @@ structseq_replace(PyStructSequence *self, PyObject *args, PyObject *kwargs)
         if (PyDict_Size(kwargs) > 0) {
             PyObject *names = PyDict_Keys(kwargs);
             if (names) {
-                PyErr_Format(PyExc_ValueError, "Got unexpected field name(s): %R", names);
+                PyErr_Format(PyExc_TypeError, "Got unexpected field name(s): %R", names);
                 Py_DECREF(names);
             }
             goto error;
