Using shutil's function to copy data between file objects instead

Moshe Zadka · Moshe Zadka · commit 37c03ff3a95d · 2000-07-29T05:15:56.000Z
of rolling our own.

Note:
This is my first sourceforge checkin. If you see anything funny about
this patch, please let me know.
diff --git a/Lib/SimpleHTTPServer.py b/Lib/SimpleHTTPServer.py
@@ -15,6 +15,7 @@
 import BaseHTTPServer
 import urllib
 import cgi
+import shutil
 from StringIO import StringIO
 
 
@@ -151,12 +152,7 @@ def copyfile(self, source, outputfile):
         to copy binary data as well.
 
         """
-
-        BLOCKSIZE = 8192
-        while 1:
-            data = source.read(BLOCKSIZE)
-            if not data: break
-            outputfile.write(data)
+        shutil.copyfileobj(source, outputfile)
 
     def guess_type(self, path):
         """Guess the type of a file.
