The second argument to start_new_thread() is not a tuple, as pointed

gvanrossum · gvanrossum · commit 38d45b7da991 · 2000-09-01T20:47:58.000Z
out by Curtis Jensen on c.l.py and forwarded by Fredrik Lundh.
diff --git a/Modules/threadmodule.c b/Modules/threadmodule.c
@@ -221,7 +221,7 @@ t_bootstrap(void *boot_raw)
 static PyObject *
 thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
 {
-	PyObject *func, *args = NULL, *keyw = NULL;
+	PyObject *func, *args, *keyw = NULL;
 	struct bootstate *boot;
 
 	if (!PyArg_ParseTuple(fargs, "OO|O:start_new_thread", &func, &args, &keyw))
@@ -233,7 +233,7 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
 	}
 	if (!PyTuple_Check(args)) {
 		PyErr_SetString(PyExc_TypeError,
-				"optional 2nd arg must be a tuple");
+				"2nd arg must be a tuple");
 		return NULL;
 	}
 	if (keyw != NULL && !PyDict_Check(keyw)) {

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ t_bootstrap(void *boot_raw)`
`221`	`221`	`static PyObject *`
`222`	`222`	`thread_PyThread_start_new_thread(PyObject self, PyObject fargs)`
`223`	`223`	`{`
`224`		`- PyObject func, args = NULL, *keyw = NULL;`
	`224`	`+ PyObject func, args, *keyw = NULL;`
`225`	`225`	`struct bootstate *boot;`
`226`	`226`
`227`	`227`	`if (!PyArg_ParseTuple(fargs, "OO\|O:start_new_thread", &func, &args, &keyw))`
`@@ -233,7 +233,7 @@ thread_PyThread_start_new_thread(PyObject self, PyObject fargs)`
`233`	`233`	`}`
`234`	`234`	`if (!PyTuple_Check(args)) {`
`235`	`235`	`PyErr_SetString(PyExc_TypeError,`
`236`		`- "optional 2nd arg must be a tuple");`
	`236`	`+ "2nd arg must be a tuple");`
`237`	`237`	`return NULL;`
`238`	`238`	`}`
`239`	`239`	`if (keyw != NULL && !PyDict_Check(keyw)) {`