Issue #17919: select.poll.poll() again works with poll.POLLNVAL on AIX.

serhiy-storchaka · serhiy-storchaka · commit 3ad2d70947a1 · 2013-12-13T12:08:01.000+02:00
diff --git a/Lib/test/test_poll.py b/Lib/test/test_poll.py
@@ -161,10 +161,6 @@ def test_poll3(self):
 
         pollster = select.poll()
         # Issue 15989
-        self.assertRaises(OverflowError, pollster.register, 0,
-                          _testcapi.SHRT_MAX + 1)
-        self.assertRaises(OverflowError, pollster.register, 0,
-                          _testcapi.USHRT_MAX + 1)
         self.assertRaises(OverflowError, pollster.poll, _testcapi.INT_MAX + 1)
         self.assertRaises(OverflowError, pollster.poll, _testcapi.UINT_MAX + 1)
 
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -29,6 +29,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #17919: select.poll.poll() again works with poll.POLLNVAL on AIX.
+
 - Issue #19063: if a Charset's body_encoding was set to None, the email
   package would generate a message claiming the Content-Transfer-Encoding
   was 7bit, and produce garbage output for the content.  This now works.
diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c
@@ -380,11 +380,10 @@ static PyObject *
 poll_register(pollObject *self, PyObject *args)
 {
     PyObject *o, *key, *value;
-    int fd;
-    short events = POLLIN | POLLPRI | POLLOUT;
+    int fd, events = POLLIN | POLLPRI | POLLOUT;
     int err;
 
-    if (!PyArg_ParseTuple(args, "O|h:register", &o, &events)) {
+    if (!PyArg_ParseTuple(args, "O|i:register", &o, &events)) {
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -380,11 +380,10 @@ static PyObject *`
`380`	`380`	`poll_register(pollObject self, PyObject args)`
`381`	`381`	`{`
`382`	`382`	`PyObject o, key, *value;`
`383`		`- int fd;`
`384`		`- short events = POLLIN \| POLLPRI \| POLLOUT;`
	`383`	`+ int fd, events = POLLIN \| POLLPRI \| POLLOUT;`
`385`	`384`	`int err;`
`386`	`385`
`387`		`- if (!PyArg_ParseTuple(args, "O\|h:register", &o, &events)) {`
	`386`	`+ if (!PyArg_ParseTuple(args, "O\|i:register", &o, &events)) {`
`388`	`387`	`return NULL;`
`389`	`388`	`}`
`390`	`389`