Address review: add PyErr_WarnFormat error handling

erlend-aasland · erlend-aasland · commit 3f942017124b · 2023-02-09T12:21:33.000+01:00
diff --git a/Modules/_sqlite/cursor.c b/Modules/_sqlite/cursor.c
@@ -664,13 +664,15 @@ bind_parameters(pysqlite_state *state, pysqlite_Statement *self,
         for (i = 0; i < num_params; i++) {
             const char *name = sqlite3_bind_parameter_name(self->st, i+1);
             if (name != NULL) {
-                PyErr_WarnFormat(PyExc_DeprecationWarning, 1,
-                                 "Binding %d ('%s') is a named parameter, "
-                                 "but you supplied a sequence which requires "
-                                 "nameless (qmark) placeholders. "
-                                 "Starting with Python 3.14 an "
-                                 "sqlite3.ProgrammingError will be raised.",
-                                 i+1, name);
+                int ret = PyErr_WarnFormat(PyExc_DeprecationWarning, 1,
+                        "Binding %d ('%s') is a named parameter, but you "
+                        "supplied a sequence which requires nameless (qmark) "
+                        "placeholders. Starting with Python 3.14 an "
+                        "sqlite3.ProgrammingError will be raised.",
+                        i+1, name);
+                if (ret < 0) {
+                    return;
+                }
             }
 
             if (PyTuple_CheckExact(parameters)) {
