asyncore: introduce a new 'closed' attribute to make sure that dispatcher gets closed only once.

giampaolo · giampaolo · commit 42e0b7f47ef3 · 2011-02-11T13:04:18.000Z
In different occasions close() might be called more than once, causing problems with already disconnected sockets/dispatchers.
diff --git a/Lib/asyncore.py b/Lib/asyncore.py
@@ -220,7 +220,7 @@ class dispatcher:
 
     connected = False
     accepting = False
-    closing = False
+    closed = False
     addr = None
     ignore_log_types = frozenset(['warning'])
 
@@ -393,14 +393,16 @@ def recv(self, buffer_size):
                 raise
 
     def close(self):
-        self.connected = False
-        self.accepting = False
-        self.del_channel()
-        try:
-            self.socket.close()
-        except socket.error as why:
-            if why.args[0] not in (ENOTCONN, EBADF):
-                raise
+        if not self.closed:
+            self.closed = True
+            self.connected = False
+            self.accepting = False
+            self.del_channel()
+            try:
+                self.socket.close()
+            except socket.error as why:
+                if why.args[0] not in (ENOTCONN, EBADF):
+                    raise
 
     # cheap inheritance, used to pass all other attribute
     # references to the underlying socket object.
