SSLContext.load_dh_params() now properly closes the input file.

pitrou · pitrou · commit 457a2292caf4 · 2013-01-12T21:43:45.000+01:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -147,6 +147,8 @@ Core and Builtins
 Library
 -------
 
+- SSLContext.load_dh_params() now properly closes the input file.
+
 - Issue #16829: IDLE printing no longer fails if there are spaces or other
   special characters in the file path.
 
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
@@ -2177,6 +2177,7 @@ load_dh_params(PySSLContext *self, PyObject *filepath)
     errno = 0;
     PySSL_BEGIN_ALLOW_THREADS
     dh = PEM_read_DHparams(f, NULL, NULL, NULL);
+    fclose(f);
     PySSL_END_ALLOW_THREADS
     if (dh == NULL) {
         if (errno != 0) {
