Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.

meadori · meadori · commit 48d49497c50e · 2011-09-27T20:52:04.000-05:00
Thanks to Suman Saha for finding the bug and providing a patch.
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -828,6 +828,7 @@ Mark Russell
 Nick Russo
 Patrick Sabin
 Sébastien Sablé
+Suman Saha
 Hajime Saitou
 George Sakkis
 Rich Salz
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -1295,6 +1295,9 @@ Tools/Demos
 Extension Modules
 -----------------
 
+- Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.
+  Thanks to Suman Saha for finding the bug and providing a patch.
+
 - Issue #13022: Fix: _multiprocessing.recvfd() doesn't check that
   file descriptor was actually received.
 
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
@@ -4474,6 +4474,7 @@ PyCArrayType_from_ctype(PyObject *itemtype, Py_ssize_t length)
     if (!PyType_Check(itemtype)) {
         PyErr_SetString(PyExc_TypeError,
                         "Expected a type object");
+        Py_DECREF(key);
         return NULL;
     }
 #ifdef MS_WIN64

Original file line number	Diff line number	Diff line change
`@@ -4474,6 +4474,7 @@ PyCArrayType_from_ctype(PyObject *itemtype, Py_ssize_t length)`
`4474`	`4474`	`if (!PyType_Check(itemtype)) {`
`4475`	`4475`	`PyErr_SetString(PyExc_TypeError,`
`4476`	`4476`	`"Expected a type object");`
	`4477`	`+ Py_DECREF(key);`
`4477`	`4478`	`return NULL;`
`4478`	`4479`	`}`
`4479`	`4480`	`#ifdef MS_WIN64`