Remove calls to currentThread() in _Condition methods that were side-effect.

brettcannon · brettcannon · commit 4b6b7f151501 · 2004-03-08T22:18:57.000Z
Side-effects were deemed unnecessary and were causing problems at shutdown
time when threads were catching exceptions at start time and then triggering
exceptions trying to call currentThread() after gc'ed.  Masked the initial
exception which was deemed bad.

Fixes bug #754449 .
diff --git a/Lib/threading.py b/Lib/threading.py
@@ -193,7 +193,6 @@ def _is_owned(self):
             return True
 
     def wait(self, timeout=None):
-        currentThread() # for side-effect
         assert self._is_owned(), "wait() of un-acquire()d lock"
         waiter = _allocate_lock()
         waiter.acquire()
@@ -235,7 +234,6 @@ def wait(self, timeout=None):
             self._acquire_restore(saved_state)
 
     def notify(self, n=1):
-        currentThread() # for side-effect
         assert self._is_owned(), "notify() of un-acquire()d lock"
         __waiters = self.__waiters
         waiters = __waiters[:n]
