Don't parenthesis in _PyObject_CallMethodId() format

vstinner · vstinner · commit 4c38154a4328 · 2016-12-09T00:33:39.000+01:00
Issue #28915: Without parenthesis, _PyObject_CallMethodId() avoids the creation a temporary tuple, and so is more efficient.
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
@@ -4673,7 +4673,7 @@ datetime_repr(PyDateTime_DateTime *self)
 static PyObject *
 datetime_str(PyDateTime_DateTime *self)
 {
-    return _PyObject_CallMethodId((PyObject *)self, &PyId_isoformat, "(s)", " ");
+    return _PyObject_CallMethodId((PyObject *)self, &PyId_isoformat, "s", " ");
 }
 
 static PyObject *
diff --git a/Modules/_decimal/_decimal.c b/Modules/_decimal/_decimal.c
@@ -5716,7 +5716,7 @@ PyInit__decimal(void)
     /* DecimalTuple */
     ASSIGN_PTR(collections, PyImport_ImportModule("collections"));
     ASSIGN_PTR(DecimalTuple, (PyTypeObject *)PyObject_CallMethod(collections,
-                                 "namedtuple", "(ss)", "DecimalTuple",
+                                 "namedtuple", "ss", "DecimalTuple",
                                  "sign digits exponent"));
 
     ASSIGN_PTR(obj, PyUnicode_FromString("decimal"));
diff --git a/Modules/_json.c b/Modules/_json.c
@@ -335,7 +335,7 @@ raise_errmsg(const char *msg, PyObject *s, Py_ssize_t end)
         if (JSONDecodeError == NULL)
             return;
     }
-    exc = PyObject_CallFunction(JSONDecodeError, "(zOn)", msg, s, end);
+    exc = PyObject_CallFunction(JSONDecodeError, "zOn", msg, s, end);
     if (exc) {
         PyErr_SetObject(JSONDecodeError, exc);
         Py_DECREF(exc);

Original file line number	Diff line number	Diff line change
`@@ -4673,7 +4673,7 @@ datetime_repr(PyDateTime_DateTime *self)`
`4673`	`4673`	`static PyObject *`
`4674`	`4674`	`datetime_str(PyDateTime_DateTime *self)`
`4675`	`4675`	`{`
`4676`		`- return _PyObject_CallMethodId((PyObject *)self, &PyId_isoformat, "(s)", " ");`
	`4676`	`+ return _PyObject_CallMethodId((PyObject *)self, &PyId_isoformat, "s", " ");`
`4677`	`4677`	`}`
`4678`	`4678`
`4679`	`4679`	`static PyObject *`
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ raise_errmsg(const char msg, PyObject s, Py_ssize_t end)`
`335`	`335`	`if (JSONDecodeError == NULL)`
`336`	`336`	`return;`
`337`	`337`	`}`
`338`		`- exc = PyObject_CallFunction(JSONDecodeError, "(zOn)", msg, s, end);`
	`338`	`+ exc = PyObject_CallFunction(JSONDecodeError, "zOn", msg, s, end);`
`339`	`339`	`if (exc) {`
`340`	`340`	`PyErr_SetObject(JSONDecodeError, exc);`
`341`	`341`	`Py_DECREF(exc);`