Cleanup logic a little. Check args first, then try to create the

jeremyhylton · jeremyhylton · commit 55087f0c351d · 2001-01-29T22:46:35.000Z
object.  This avoids creation + decref if bogus arguments are passed.
diff --git a/Modules/shamodule.c b/Modules/shamodule.c
@@ -491,16 +491,15 @@ SHA_new(PyObject *self, PyObject *args, PyObject *kwdict)
     SHAobject *new;
     unsigned char *cp = NULL;
     int len;
-	
-    if ((new = newSHAobject()) == NULL)
-        return NULL;
 
     if (!PyArg_ParseTupleAndKeywords(args, kwdict, "|s#:new", kwlist,
                                      &cp, &len)) {
-        Py_DECREF(new);
         return NULL;
     }
 
+    if ((new = newSHAobject()) == NULL)
+        return NULL;
+
     sha_init(new);
 
     if (PyErr_Occurred()) {
