bpo-40670: More reliable validation of statements in timeit.Timer. (GH-22358)

serhiy-storchaka · web-flow · commit 557b9a52edc4 · 2020-09-22T16:16:46.000+03:00
It now accepts "empty" statements (only whitespaces and comments)
and rejects misindentent statements.
diff --git a/Lib/test/test_timeit.py b/Lib/test/test_timeit.py
@@ -77,6 +77,9 @@ def test_timer_invalid_stmt(self):
         self.assertRaises(SyntaxError, timeit.Timer, stmt='break')
         self.assertRaises(SyntaxError, timeit.Timer, stmt='continue')
         self.assertRaises(SyntaxError, timeit.Timer, stmt='from timeit import *')
+        self.assertRaises(SyntaxError, timeit.Timer, stmt='  pass')
+        self.assertRaises(SyntaxError, timeit.Timer,
+                          setup='while False:\n  pass', stmt='  break')
 
     def test_timer_invalid_setup(self):
         self.assertRaises(ValueError, timeit.Timer, setup=None)
@@ -86,6 +89,12 @@ def test_timer_invalid_setup(self):
         self.assertRaises(SyntaxError, timeit.Timer, setup='break')
         self.assertRaises(SyntaxError, timeit.Timer, setup='continue')
         self.assertRaises(SyntaxError, timeit.Timer, setup='from timeit import *')
+        self.assertRaises(SyntaxError, timeit.Timer, setup='  pass')
+
+    def test_timer_empty_stmt(self):
+        timeit.Timer(stmt='')
+        timeit.Timer(stmt=' \n\t\f')
+        timeit.Timer(stmt='# comment')
 
     fake_setup = "import timeit\ntimeit._fake_timer.setup()"
     fake_stmt = "import timeit\ntimeit._fake_timer.inc()"
diff --git a/Lib/timeit.py b/Lib/timeit.py
@@ -72,6 +72,7 @@ def inner(_it, _timer{init}):
     _t0 = _timer()
     for _i in _it:
         {stmt}
+        pass
     _t1 = _timer()
     return _t1 - _t0
 """
diff --git a/Misc/NEWS.d/next/Library/2020-09-22-14-55-34.bpo-40670.R5sm68.rst b/Misc/NEWS.d/next/Library/2020-09-22-14-55-34.bpo-40670.R5sm68.rst
@@ -0,0 +1,3 @@
+More reliable validation of statements in :class:`timeit.Timer`. It now
+accepts "empty" statements (only whitespaces and comments) and rejects
+misindentent statements.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+More reliable validation of statements in :class:`timeit.Timer`. It now
	`2`	`+accepts "empty" statements (only whitespaces and comments) and rejects`
	`3`	`+misindentent statements.`