Issue #14168: Check for presence of _attrs before accessing it.

loewis · loewis · commit 67245a6ed4a5 · 2012-03-05T07:01:49.000+01:00
diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py
@@ -362,11 +362,17 @@ def testChangeAttr(self):
     def testGetAttrList(self):
         pass
 
-    def testGetAttrValues(self): pass
+    def testGetAttrValues(self):
+        pass
 
-    def testGetAttrLength(self): pass
+    def testGetAttrLength(self):
+        pass
 
-    def testGetAttribute(self): pass
+    def testGetAttribute(self):
+        dom = Document()
+        child = dom.appendChild(
+            dom.createElementNS("http://www.python.org", "python:abc"))
+        self.assertEqual(child.getAttribute('missing'), '')
 
     def testGetAttributeNS(self):
         dom = Document()
@@ -378,6 +384,9 @@ def testGetAttributeNS(self):
             'http://www.python.org')
         self.assertEqual(child.getAttributeNS("http://www.w3.org", "other"),
             '')
+        child2 = child.appendChild(dom.createElement('abc'))
+        self.assertEqual(child2.getAttributeNS("http://www.python.org", "missing"),
+                         '')
 
     def testGetAttributeNode(self): pass
 
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
@@ -723,12 +723,16 @@ def unlink(self):
         Node.unlink(self)
 
     def getAttribute(self, attname):
+        if self._attrs is None:
+            return ""
         try:
             return self._attrs[attname].value
         except KeyError:
             return ""
 
     def getAttributeNS(self, namespaceURI, localName):
+        if self._attrsNS is None:
+            return ""
         try:
             return self._attrsNS[(namespaceURI, localName)].value
         except KeyError:
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -511,6 +511,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #14168: Check for presence of _attrs before accessing it.
+
 - Issue #14195: An issue that caused weakref.WeakSet instances to incorrectly
   return True for a WeakSet instance 'a' in both 'a < a' and 'a > a' has been
   fixed.
