#777884: make .normalize() do nothing for childless nodes, instead of raising an exception

akuchling · akuchling · commit 688b9e384e06 · 2010-07-25T23:38:47.000Z
diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py
@@ -951,6 +951,14 @@ def testNormalizeRecursion(self):
         doc.unlink()
 
 
+    def testBug0777884(self):
+        doc = parseString("<o>text</o>")
+        text = doc.documentElement.childNodes[0]
+        self.assertEquals(text.nodeType, Node.TEXT_NODE)
+        # Should run quietly, doing nothing.
+        text.normalize()
+        doc.unlink()
+
     def testBug1433694(self):
         doc = parseString("<o><i/>t</o>")
         node = doc.documentElement
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
@@ -920,6 +920,10 @@ def removeChild(self, oldChild):
         raise xml.dom.NotFoundErr(
             self.nodeName + " nodes do not have children")
 
+    def normalize(self):
+        # For childless nodes, normalize() has nothing to do.
+        pass
+
     def replaceChild(self, newChild, oldChild):
         raise xml.dom.HierarchyRequestErr(
             self.nodeName + " nodes do not have children")
