Fix test_bad_address on Ubuntu 13.04

pitrou · pitrou · commit 6b5a38c728bb · 2013-05-25T13:08:13.000+02:00
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py
@@ -116,7 +116,10 @@ def test_bad_address(self):
         bogus_domain = "sadflkjsasf.i.nvali.d"
         try:
             socket.gethostbyname(bogus_domain)
-        except socket.gaierror:
+        except OSError:
+            # socket.gaierror is too narrow, since getaddrinfo() may also
+            # fail with EAI_SYSTEM and ETIMEDOUT (seen on Ubuntu 13.04),
+            # i.e. Python's TimeoutError.
             pass
         else:
             # This happens with some overzealous DNS providers such as OpenDNS
