Changes to what we do to modules that don't import, as

Michael W. Hudson · Michael W. Hudson · commit 7113d9607bcc · 2002-03-01T14:16:31.000Z
discussed on python-dev.
diff --git a/setup.py b/setup.py
@@ -176,13 +176,13 @@ def build_extension(self, ext):
         except ImportError, why:
 
             if 1:
-                self.announce('*** WARNING: removing "%s" since importing it'
+                self.announce('*** WARNING: renaming "%s" since importing it'
                               ' failed: %s' % (ext.name, why))
                 assert not self.inplace
-                fullname = self.get_ext_fullname(ext.name)
-                ext_filename = os.path.join(self.build_lib,
-                                            self.get_ext_filename(fullname))
-                os.remove(ext_filename)
+                basename, tail = os.path.splitext(ext_filename)
+                newname = basename + "_failed" + tail
+                if os.path.exists(newname): os.remove(newname)
+                os.rename(ext_filename, newname)
 
                 # XXX -- This relies on a Vile HACK in
                 # distutils.command.build_ext.build_extension().  The
