Fix os._DummyDirEntry.is_symlink()

vstinner · vstinner · commit 73030df77f05 · 2016-03-29T11:25:00.000+02:00
Issue #25911: Fix os._DummyDirEntry.is_symlink(), don't follow symbolic links: use os.stat(path, follow_symlinks=False).
diff --git a/Lib/os.py b/Lib/os.py
@@ -452,22 +452,33 @@ def __init__(self, dir, name):
         # Mimick FindFirstFile/FindNextFile: we should get file attributes
         # while iterating on a directory
         self._stat = None
+        self._lstat = None
         try:
-            self.stat()
+            self.stat(follow_symlinks=False)
         except OSError:
             pass
 
-    def stat(self):
-        if self._stat is None:
-            self._stat = stat(self.path)
-        return self._stat
+    def stat(self, *, follow_symlinks=True):
+        if follow_symlinks:
+            if self._stat is None:
+                self._stat = stat(self.path)
+            return self._stat
+        else:
+            if self._lstat is None:
+                self._lstat = stat(self.path, follow_symlinks=False)
+            return self._lstat
 
     def is_dir(self):
+        if self._lstat is not None and not self.is_symlink():
+            # use the cache lstat
+            stat = self.stat(follow_symlinks=False)
+            return st.S_ISDIR(stat.st_mode)
+
         stat = self.stat()
         return st.S_ISDIR(stat.st_mode)
 
     def is_symlink(self):
-        stat = self.stat()
+        stat = self.stat(follow_symlinks=False)
         return st.S_ISLNK(stat.st_mode)
 
 class _dummy_scandir:
