Return -1 for errors.

gvanrossum · gvanrossum · commit 73531a3bae55 · 1990-12-20T23:12:40.000Z
diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
@@ -107,7 +107,7 @@ module_setattr(m, name, v)
 {
 	if (strcmp(name, "__dict__") == 0 || strcmp(name, "__name__") == 0) {
 		err_setstr(NameError, "can't assign to reserved member name");
-		return NULL;
+		return -1;
 	}
 	if (v == NULL)
 		return dictremove(m->md_dict, name);
diff --git a/Objects/object.c b/Objects/object.c
@@ -157,7 +157,7 @@ setattr(v, name, w)
 			err_setstr(TypeError, "attribute-less object");
 		else
 			err_setstr(TypeError, "object has read-only attributes");
-		return NULL;
+		return -1;
 	}
 	else {
 		return (*v->ob_type->tp_setattr)(v, name, w);
diff --git a/Python/structmember.c b/Python/structmember.c
@@ -130,5 +130,5 @@ setmember(addr, mlist, name, v)
 	}
 	
 	err_setstr(NameError, name);
-	return NULL;
+	return -1;
 }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ module_setattr(m, name, v)`
`107`	`107`	`{`
`108`	`108`	`if (strcmp(name, "__dict__") == 0 \|\| strcmp(name, "__name__") == 0) {`
`109`	`109`	`err_setstr(NameError, "can't assign to reserved member name");`
`110`		`- return NULL;`
	`110`	`+ return -1;`
`111`	`111`	`}`
`112`	`112`	`if (v == NULL)`
`113`	`113`	`return dictremove(m->md_dict, name);`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ setattr(v, name, w)`
`157`	`157`	`err_setstr(TypeError, "attribute-less object");`
`158`	`158`	`else`
`159`	`159`	`err_setstr(TypeError, "object has read-only attributes");`
`160`		`- return NULL;`
	`160`	`+ return -1;`
`161`	`161`	`}`
`162`	`162`	`else {`
`163`	`163`	`return (*v->ob_type->tp_setattr)(v, name, w);`