Issue #19437: Fix select.epoll.poll(), fix code handling PyMem_New() error

vstinner · vstinner · commit 7613542a27a0 · 2013-10-30T19:57:52.000+01:00
The bug was introduced with the select.epoll module! So it's 5 years old :-)
diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c
@@ -1459,7 +1459,6 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds)
 
     evs = PyMem_New(struct epoll_event, maxevents);
     if (evs == NULL) {
-        Py_DECREF(self);
         PyErr_NoMemory();
         return NULL;
     }

Original file line number	Diff line number	Diff line change
`@@ -1459,7 +1459,6 @@ pyepoll_poll(pyEpoll_Object self, PyObject args, PyObject *kwds)`
`1459`	`1459`
`1460`	`1460`	`evs = PyMem_New(struct epoll_event, maxevents);`
`1461`	`1461`	`if (evs == NULL) {`
`1462`		`- Py_DECREF(self);`
`1463`	`1462`	`PyErr_NoMemory();`
`1464`	`1463`	`return NULL;`
`1465`	`1464`	`}`