correctly lookup __dir__

benjaminp · benjaminp · commit 7963a35b417d · 2011-05-23T16:11:05.000-05:00
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
@@ -1595,6 +1595,7 @@ def some_number(self_, key):
             # probably not worth it.
             # ("__enter__", run_context, iden),
             # ("__exit__", run_context, iden),
+            ("__dir__", dir, empty_seq, set(), {}),
             ]
 
         class Checker(object):
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.1.4?
 Core and Builtins
 -----------------
 
+- Correct lookup of __dir__ on objects. Among other things, this causes errors
+  besides AttributeError found on lookup to be propagated.
+
 - Issue #12060: Use sig_atomic_t type and volatile keyword in the signal
   module. Patch written by Charles-François Natali.
 
diff --git a/Objects/object.c b/Objects/object.c
@@ -1348,14 +1348,15 @@ _generic_dir(PyObject *obj)
 static PyObject *
 _dir_object(PyObject *obj)
 {
-    PyObject * result = NULL;
-    PyObject * dirfunc = PyObject_GetAttrString((PyObject*)obj->ob_type,
-                                                "__dir__");
+    PyObject *result = NULL;
+    static PyObject *dir_str = NULL;
+    PyObject *dirfunc = _PyObject_LookupSpecial(obj, "__dir__", &dir_str);
 
     assert(obj);
     if (dirfunc == NULL) {
+        if (PyErr_Occurred())
+            return NULL;
         /* use default implementation */
-        PyErr_Clear();
         if (PyModule_Check(obj))
             result = _specialized_dir_module(obj);
         else if (PyType_Check(obj))
@@ -1365,7 +1366,7 @@ _dir_object(PyObject *obj)
     }
     else {
         /* use __dir__ */
-        result = PyObject_CallFunctionObjArgs(dirfunc, obj, NULL);
+        result = PyObject_CallFunctionObjArgs(dirfunc, NULL);
         Py_DECREF(dirfunc);
         if (result == NULL)
             return NULL;

Original file line number	Diff line number	Diff line change
`@@ -1595,6 +1595,7 @@ def some_number(self_, key):`
`1595`	`1595`	`# probably not worth it.`
`1596`	`1596`	`# ("__enter__", run_context, iden),`
`1597`	`1597`	`# ("__exit__", run_context, iden),`
	`1598`	`+ ("__dir__", dir, empty_seq, set(), {}),`
`1598`	`1599`	`]`
`1599`	`1600`
`1600`	`1601`	`class Checker(object):`