Issue #21520: test_zipfile no longer fails if the word 'bad' appears

larryhastings · larryhastings · commit 7e63b36f7f69 · 2015-05-08T06:54:58.000-07:00
anywhere in the name of the current directory.
diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py
@@ -719,9 +719,10 @@ def test_write_filtered_python_package(self):
             self.assertTrue('SyntaxError' not in reportStr)
 
             # then check that the filter works on individual files
+            def filter(path):
+                return not os.path.basename(path).startswith("bad")
             with captured_stdout() as reportSIO, self.assertWarns(UserWarning):
-                zipfp.writepy(packagedir, filterfunc=lambda fn:
-                                                     'bad' not in fn)
+                zipfp.writepy(packagedir, filterfunc=filter)
             reportStr = reportSIO.getvalue()
             if reportStr:
                 print(reportStr)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -228,6 +228,9 @@ Library
 Tests
 -----
 
+- Issue #21520: test_zipfile no longer fails if the word 'bad' appears
+  anywhere in the name of the current directory.
+
 - Issue #23799: Added test.support.start_threads() for running and
   cleaning up multiple threads.
 
