Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 827f5d3

Browse files
committed
Issue #19665: Increased timeout for SMTPHandler test.
1 parent 7601a1e commit 827f5d3

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

Lib/test/test_logging.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -959,19 +959,21 @@ def server_close(self):
959959

960960
@unittest.skipUnless(threading, 'Threading required for this test.')
961961
class SMTPHandlerTest(BaseTest):
962+
TIMEOUT = 8.0
962963
def test_basic(self):
963964
sockmap = {}
964965
server = TestSMTPServer(('localhost', 0), self.process_message, 0.001,
965966
sockmap)
966967
server.start()
967968
addr = ('localhost', server.port)
968-
h = logging.handlers.SMTPHandler(addr, 'me', 'you', 'Log', timeout=5.0)
969+
h = logging.handlers.SMTPHandler(addr, 'me', 'you', 'Log',
970+
timeout=self.TIMEOUT)
969971
self.assertEqual(h.toaddrs, ['you'])
970972
self.messages = []
971973
r = logging.makeLogRecord({'msg': 'Hello'})
972974
self.handled = threading.Event()
973975
h.handle(r)
974-
self.handled.wait(5.0) # 14314: don't wait forever
976+
self.handled.wait(self.TIMEOUT) # 14314: don't wait forever
975977
server.stop()
976978
self.assertTrue(self.handled.is_set())
977979
self.assertEqual(len(self.messages), 1)

0 commit comments

Comments
 (0)