bpo-38761: Register WeakSet as a MutableSet (GH-17104)

rhettinger · web-flow · commit 84ac4376587e · 2019-11-10T20:12:04.000-08:00
diff --git a/Lib/test/test_weakset.py b/Lib/test/test_weakset.py
@@ -2,6 +2,7 @@
 from weakref import WeakSet
 import string
 from collections import UserString as ustr
+from collections.abc import Set, MutableSet
 import gc
 import contextlib
 
@@ -437,6 +438,10 @@ def test_len_race(self):
     def test_repr(self):
         assert repr(self.s) == repr(self.s.data)
 
+    def test_abc(self):
+        self.assertIsInstance(self.s, Set)
+        self.assertIsInstance(self.s, MutableSet)
+
 
 if __name__ == "__main__":
     unittest.main()
diff --git a/Lib/weakref.py b/Lib/weakref.py
@@ -33,6 +33,9 @@
            "WeakSet", "WeakMethod", "finalize"]
 
 
+_collections_abc.Set.register(WeakSet)
+_collections_abc.MutableSet.register(WeakSet)
+
 class WeakMethod(ref):
     """
     A custom `weakref.ref` subclass which simulates a weak reference to
diff --git a/Misc/NEWS.d/next/Library/2019-11-10-13-40-33.bpo-38761.P1UUIZ.rst b/Misc/NEWS.d/next/Library/2019-11-10-13-40-33.bpo-38761.P1UUIZ.rst
@@ -0,0 +1 @@
+WeakSet is now registered as a collections.abc.MutableSet.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+WeakSet is now registered as a collections.abc.MutableSet.`