Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 85d6edf

Browse files
committed
Remove silly EMPTYSTRING global. Saves a global lookup.
1 parent b3acd3e commit 85d6edf

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

Lib/StringIO.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@
3636

3737
__all__ = ["StringIO"]
3838

39-
EMPTYSTRING = ''
40-
4139
class StringIO:
4240
def __init__(self, buf = ''):
4341
self.buf = buf
@@ -61,7 +59,7 @@ def seek(self, pos, mode = 0):
6159
if self.closed:
6260
raise ValueError, "I/O operation on closed file"
6361
if self.buflist:
64-
self.buf += EMPTYSTRING.join(self.buflist)
62+
self.buf += ''.join(self.buflist)
6563
self.buflist = []
6664
if mode == 1:
6765
pos += self.pos
@@ -78,7 +76,7 @@ def read(self, n = -1):
7876
if self.closed:
7977
raise ValueError, "I/O operation on closed file"
8078
if self.buflist:
81-
self.buf += EMPTYSTRING.join(self.buflist)
79+
self.buf += ''.join(self.buflist)
8280
self.buflist = []
8381
if n < 0:
8482
newpos = self.len
@@ -92,7 +90,7 @@ def readline(self, length=None):
9290
if self.closed:
9391
raise ValueError, "I/O operation on closed file"
9492
if self.buflist:
95-
self.buf += EMPTYSTRING.join(self.buflist)
93+
self.buf += ''.join(self.buflist)
9694
self.buflist = []
9795
i = self.buf.find('\n', self.pos)
9896
if i < 0:
@@ -139,7 +137,7 @@ def write(self, s):
139137
newpos = self.pos + len(s)
140138
if self.pos < self.len:
141139
if self.buflist:
142-
self.buf += EMPTYSTRING.join(self.buflist)
140+
self.buf += ''.join(self.buflist)
143141
self.buflist = []
144142
self.buflist = [self.buf[:self.pos], s, self.buf[newpos:]]
145143
self.buf = ''
@@ -151,15 +149,15 @@ def write(self, s):
151149
self.pos = newpos
152150

153151
def writelines(self, list):
154-
self.write(EMPTYSTRING.join(list))
152+
self.write(''.join(list))
155153

156154
def flush(self):
157155
if self.closed:
158156
raise ValueError, "I/O operation on closed file"
159157

160158
def getvalue(self):
161159
if self.buflist:
162-
self.buf += EMPTYSTRING.join(self.buflist)
160+
self.buf += ''.join(self.buflist)
163161
self.buflist = []
164162
return self.buf
165163

0 commit comments

Comments
 (0)