Remove _Py_ResetReferences. Fixes bug #529750 "Circular reference makes

nascheme · nascheme · commit 89350a41b969 · 2002-11-17T17:52:44.000Z
Py_Init crash".  refchain cannot be cleared because objects can live across
Py_Finalize() and Py_Initialize() if they are kept alive by circular
references.
diff --git a/Include/object.h b/Include/object.h
@@ -559,7 +559,6 @@ PyAPI_FUNC(void) _Py_NewReference(PyObject *);
 PyAPI_FUNC(void) _Py_ForgetReference(PyObject *);
 PyAPI_FUNC(void) _Py_Dealloc(PyObject *);
 PyAPI_FUNC(void) _Py_PrintReferences(FILE *);
-PyAPI_FUNC(void) _Py_ResetReferences(void);
 
 #else
 /* Without Py_TRACE_REFS, there's little enough to do that we expand code
diff --git a/Objects/object.c b/Objects/object.c
@@ -1908,13 +1908,6 @@ _Py_ReadyTypes(void)
 
 static PyObject refchain = {&refchain, &refchain};
 
-void
-_Py_ResetReferences(void)
-{
-	refchain._ob_prev = refchain._ob_next = &refchain;
-	_Py_RefTotal = 0;
-}
-
 void
 _Py_NewReference(PyObject *op)
 {
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -277,10 +277,6 @@ Py_Finalize(void)
 #endif
 
 	call_ll_exitfuncs();
-
-#ifdef Py_TRACE_REFS
-	_Py_ResetReferences();
-#endif /* Py_TRACE_REFS */
 }
 
 /* Create and initialize a new interpreter and thread, and return the

Original file line number	Diff line number	Diff line change
`@@ -277,10 +277,6 @@ Py_Finalize(void)`
`277`	`277`	`#endif`
`278`	`278`
`279`	`279`	`call_ll_exitfuncs();`
`280`		`-`
`281`		`-#ifdef Py_TRACE_REFS`
`282`		`- _Py_ResetReferences();`
`283`		`-#endif /* Py_TRACE_REFS */`
`284`	`280`	`}`
`285`	`281`
`286`	`282`	`/* Create and initialize a new interpreter and thread, and return the`