_testmultiphase: Fix possible ref leak (GH-22881)

corona10 · web-flow · commit 8a9463f2d404 · 2020-10-22T02:44:18.000-07:00
This is just test code, but sometimes external contributors reference the code snippets from test code. `PyModule_AddObject` should be handled in the proper way. https://docs.python.org/3/c-api/module.html#c.PyModule_AddObject
diff --git a/Modules/_testmultiphase.c b/Modules/_testmultiphase.c
@@ -359,6 +359,7 @@ static int execfunc(PyObject *m)
         goto fail;
     }
     if (PyModule_AddObject(m, "Example", temp) != 0) {
+        Py_DECREF(temp);
         goto fail;
     }
 
@@ -369,6 +370,7 @@ static int execfunc(PyObject *m)
         goto fail;
     }
     if (PyModule_AddObject(m, "error", temp) != 0) {
+        Py_DECREF(temp);
         goto fail;
     }
 
@@ -378,6 +380,7 @@ static int execfunc(PyObject *m)
         goto fail;
     }
     if (PyModule_AddObject(m, "Str", temp) != 0) {
+        Py_DECREF(temp);
         goto fail;
     }
 
@@ -807,6 +810,7 @@ meth_state_access_exec(PyObject *m)
         return -1;
     }
     if (PyModule_AddObject(m, "StateAccessType", temp) != 0) {
+        Py_DECREF(temp);
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -359,6 +359,7 @@ static int execfunc(PyObject *m)`
`359`	`359`	`goto fail;`
`360`	`360`	`}`
`361`	`361`	`if (PyModule_AddObject(m, "Example", temp) != 0) {`
	`362`	`+ Py_DECREF(temp);`
`362`	`363`	`goto fail;`
`363`	`364`	`}`
`364`	`365`
`@@ -369,6 +370,7 @@ static int execfunc(PyObject *m)`
`369`	`370`	`goto fail;`
`370`	`371`	`}`
`371`	`372`	`if (PyModule_AddObject(m, "error", temp) != 0) {`
	`373`	`+ Py_DECREF(temp);`
`372`	`374`	`goto fail;`
`373`	`375`	`}`
`374`	`376`
`@@ -378,6 +380,7 @@ static int execfunc(PyObject *m)`
`378`	`380`	`goto fail;`
`379`	`381`	`}`
`380`	`382`	`if (PyModule_AddObject(m, "Str", temp) != 0) {`
	`383`	`+ Py_DECREF(temp);`
`381`	`384`	`goto fail;`
`382`	`385`	`}`
`383`	`386`
`@@ -807,6 +810,7 @@ meth_state_access_exec(PyObject *m)`
`807`	`810`	`return -1;`
`808`	`811`	`}`
`809`	`812`	`if (PyModule_AddObject(m, "StateAccessType", temp) != 0) {`
	`813`	`+ Py_DECREF(temp);`
`810`	`814`	`return -1;`
`811`	`815`	`}`
`812`	`816`