When time.localtime() is passed a tick count the platform C localtime()

tim-one · tim-one · commit 8b19a93b87d6 · 2003-01-17T20:08:54.000Z
function can't handle, don't raise IOError -- that doesn't make sense.
Raise ValueError instead.

Bugfix candidate.
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
@@ -273,7 +273,7 @@ time_convert(time_t when, struct tm * (*function)(const time_t *))
 		if (errno == 0)
 			errno = EINVAL;
 #endif
-		return PyErr_SetFromErrno(PyExc_IOError);
+		return PyErr_SetFromErrno(PyExc_ValueError);
 	}
 	return tmtotuple(p);
 }

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ time_convert(time_t when, struct tm * (function)(const time_t ))`
`273`	`273`	`if (errno == 0)`
`274`	`274`	`errno = EINVAL;`
`275`	`275`	`#endif`
`276`		`- return PyErr_SetFromErrno(PyExc_IOError);`
	`276`	`+ return PyErr_SetFromErrno(PyExc_ValueError);`
`277`	`277`	`}`
`278`	`278`	`return tmtotuple(p);`
`279`	`279`	`}`