don't leak if the __class__ closure is set

benjaminp · benjaminp · commit 8e8fbeae27e3 · 2012-06-01T23:57:36.000-07:00
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -158,10 +158,8 @@ builtin___build_class__(PyObject *self, PyObject *args, PyObject *kwds)
             cls = PyEval_CallObjectWithKeywords(meta, margs, mkw);
             Py_DECREF(margs);
         }
-        if (cls != NULL && PyCell_Check(cell)) {
-            Py_INCREF(cls);
-            PyCell_SET(cell, cls);
-        }
+        if (cls != NULL && PyCell_Check(cell))
+            PyCell_Set(cell, cls);
         Py_DECREF(cell);
     }
     Py_DECREF(ns);

Original file line number	Diff line number	Diff line change
`@@ -158,10 +158,8 @@ builtin___build_class__(PyObject self, PyObject args, PyObject *kwds)`
`158`	`158`	`cls = PyEval_CallObjectWithKeywords(meta, margs, mkw);`
`159`	`159`	`Py_DECREF(margs);`
`160`	`160`	`}`
`161`		`- if (cls != NULL && PyCell_Check(cell)) {`
`162`		`- Py_INCREF(cls);`
`163`		`- PyCell_SET(cell, cls);`
`164`		`- }`
	`161`	`+ if (cls != NULL && PyCell_Check(cell))`
	`162`	`+ PyCell_Set(cell, cls);`
`165`	`163`	`Py_DECREF(cell);`
`166`	`164`	`}`
`167`	`165`	`Py_DECREF(ns);`