Remove bogus assertions

JelleZijlstra · JelleZijlstra · commit 8f54b029dc84 · 2023-05-09T18:35:43.000-07:00
diff --git a/Lib/test/test_type_params.py b/Lib/test/test_type_params.py
@@ -344,11 +344,13 @@ def meth(self):
                 return "base"
 
         class Child(Base):
-            def meth[T](self) -> T:
+            # Having int in the annotation ensures the class gets cells for both
+            # __class__ and __classdict__
+            def meth[T](self, arg: int) -> T:
                 return super().meth() + "child"
 
         c = Child()
-        self.assertEqual(c.meth(), "basechild")
+        self.assertEqual(c.meth(1), "basechild")
 
 
 def global_generic_func[T]():
diff --git a/Python/compile.c b/Python/compile.c
@@ -2464,7 +2464,6 @@ compiler_class_body(struct compiler *c, stmt_ty s, int firstlineno)
             compiler_exit_scope(c);
             return ERROR;
         }
-        assert(i == 0);
         ADDOP_I(c, NO_LOCATION, LOAD_CLOSURE, i);
         ADDOP_I(c, NO_LOCATION, COPY, 1);
         if (compiler_nameop(c, NO_LOCATION, &_Py_ID(__classcell__), Store) < 0) {
@@ -2474,8 +2473,6 @@ compiler_class_body(struct compiler *c, stmt_ty s, int firstlineno)
     }
     else {
         /* No methods referenced __class__, so just return None */
-        assert(PyDict_GET_SIZE(c->u->u_metadata.u_cellvars) ==
-                c->u->u_ste->ste_needs_classdict ? 1 : 0);
         ADDOP_LOAD_CONST(c, NO_LOCATION, Py_None);
     }
     ADDOP_IN_SCOPE(c, NO_LOCATION, RETURN_VALUE);

Original file line number	Diff line number	Diff line change
`@@ -2464,7 +2464,6 @@ compiler_class_body(struct compiler *c, stmt_ty s, int firstlineno)`
`2464`	`2464`	`compiler_exit_scope(c);`
`2465`	`2465`	`return ERROR;`
`2466`	`2466`	`}`
`2467`		`- assert(i == 0);`
`2468`	`2467`	`ADDOP_I(c, NO_LOCATION, LOAD_CLOSURE, i);`
`2469`	`2468`	`ADDOP_I(c, NO_LOCATION, COPY, 1);`
`2470`	`2469`	`if (compiler_nameop(c, NO_LOCATION, &_Py_ID(__classcell__), Store) < 0) {`
`@@ -2474,8 +2473,6 @@ compiler_class_body(struct compiler *c, stmt_ty s, int firstlineno)`
`2474`	`2473`	`}`
`2475`	`2474`	`else {`
`2476`	`2475`	`/* No methods referenced __class__, so just return None */`
`2477`		`- assert(PyDict_GET_SIZE(c->u->u_metadata.u_cellvars) ==`
`2478`		`- c->u->u_ste->ste_needs_classdict ? 1 : 0);`
`2479`	`2476`	`ADDOP_LOAD_CONST(c, NO_LOCATION, Py_None);`
`2480`	`2477`	`}`
`2481`	`2478`	`ADDOP_IN_SCOPE(c, NO_LOCATION, RETURN_VALUE);`